This repository was archived by the owner on Jan 27, 2020. It is now read-only.
Fix RunMultiQC error#657
Merged
szilvajuhos merged 2 commits intoSciLifeLab:devfrom Oct 1, 2018
Merged
Conversation
alneberg
approved these changes
Sep 26, 2018
| qualimap --version &> v_qualimap.txt | ||
| samtools --version &> v_samtools.txt | ||
| vcftools --version > v_vcftools.txt | ||
| configManta.py --version > v_manta.txt 2>&1 || true |
Member
There was a problem hiding this comment.
Will be much harder to spot errors with MultiQC if we ignore all potential version fetching errors, no?
Member
Author
There was a problem hiding this comment.
I guess it doesn't really matter, because, if a tool is failing, it will be seen when we're really using the tool, not when we want to check its version.
Worst case scenario here, we won't have it display properly.
szilvajuhos
approved these changes
Oct 1, 2018
Collaborator
|
Looks OK for me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Process
GetVersionAllwas not working.2 different issues:
Not launching when nothing in
directoryMap.version-Fixed by adding
.ifEmpty(file ("empty"))to the input channelsamtoolsandvcftoolswhere not giving out versions, and somehow blocking the execution of the rest of the process.2>&1 || trueafter launching each toolPR checklist
devbranch./scripts/test.sh -p docker -t ALL).CHANGELOG.mdis updated